Past simple or present perfect? 1)the weather (be) good when you (be) on holiday?

Question

Past simple or present perfect?
1)the weather (be) good when you (be) on holiday?

Answer 1

The weather was good when you were on holiday..